-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft of following flake-lang everywhere #193
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! If you could make sure the lb-cardano-demo works when these changes are done that would be great. It's basically our only canary test :D
1a1c6c7
to
1192cc6
Compare
af9aa8e
to
53ff09f
Compare
Okay, some final numbers
Further workIf we want to get this to back to be the numbers in the original PR, we'll need to modify the plutus-ledger-api-rust since that's contributing a significant overhead e.g. the following patch diff --git a/flake.nix b/flake.nix
index 792c091..5b02a10 100644
--- a/flake.nix
+++ b/flake.nix
@@ -39,10 +39,10 @@
};
# Rust runtime
- plutus-ledger-api-rust = {
- url = "github:mlabs-haskell/plutus-ledger-api-rust";
- inputs.nixpkgs.follows = "nixpkgs";
- };
+ # plutus-ledger-api-rust = {
+ # url = "github:mlabs-haskell/plutus-ledger-api-rust";
+ # inputs.nixpkgs.follows = "nixpkgs";
+ # };
};
outputs = inputs@{ flake-parts, ... }: gives us the following
(of course, we wouldn't want to just comment it out because we probably need it somewhere -- I'm fairly certain the problem is the cyclic reference from lambda-buffers to plutus-ledger-api-rust; and if we could remove the cyclic reference, we could make plutus-ledger-api-rust follow lambda-buffer's flake-lang to significantly reduce the flake.lock size.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
…ng-as-much-as-possible
4a763e0
to
8f0eb6e
Compare
More putting
follows
everywhere.Before this PR:
EDIT: we don't have such nice performance anymore -- see below
After this PR: