Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to perform automated spell checking #941

Merged
merged 15 commits into from
Nov 21, 2024

Conversation

szmazurek
Copy link
Collaborator

@szmazurek szmazurek commented Sep 16, 2024

Fixes #ISSUE_NUMBER

Proposed Changes

  • added CI for spellchecker

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@szmazurek szmazurek requested a review from a team as a code owner September 16, 2024 13:12
Copy link
Contributor

github-actions bot commented Sep 16, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

.github/workflows/spellchecker.yml Fixed Show fixed Hide fixed
.github/workflows/spellchecker.yml Fixed Show fixed Hide fixed
.github/workflows/spellchecker.yml Fixed Show fixed Hide fixed
@szmazurek
Copy link
Collaborator Author

@sarthakpati check the output of the spellchecker action, this will probably need some more customization, I also have no idea why it complains about yaml extension

@sarthakpati
Copy link
Collaborator

Add a new file called .spelling to the repo with the following:

words:
  - yml
  - yaml
  - gandlf
  - GaNDLF

Update the action to use this file:

# previous steps go here
      - name: Spellcheck
        uses: check-spelling/check-spelling@main
        with:
          config: .spelling ## this is needed

GANDLF/some_misspled_file_nmae.py Fixed Show fixed Hide fixed
GANDLF/some_misspled_file_nmae.py Fixed Show fixed Hide fixed
GANDLF/some_misspled_file_nmae.py Fixed Show fixed Hide fixed
GANDLF/some_misspled_file_nmae.py Fixed Show fixed Hide fixed
GANDLF/some_misspled_file_nmae.py Fixed Show fixed Hide fixed
GANDLF/some_misspled_file_nmae.py Fixed Show fixed Hide fixed
GANDLF/some_misspled_file_nmae.py Fixed Show fixed Hide fixed
GANDLF/some_misspled_file_nmae.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.99%. Comparing base (966f84f) to head (60eda6c).

Files with missing lines Patch % Lines
GANDLF/cli/huggingface_hub_handler.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   92.00%   91.99%   -0.02%     
==========================================
  Files         171      171              
  Lines       10006    10006              
==========================================
- Hits         9206     9205       -1     
- Misses        800      801       +1     
Flag Coverage Δ
unittests 91.99% <80.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sarthakpati
Copy link
Collaborator

@szmazurek it seems like the CI is working, no? Can you please take a look and fix the misspelt words so that we can merge?

@sarthakpati
Copy link
Collaborator

Hey @szmazurek is this good to merge?

@sarthakpati sarthakpati changed the title Spellchecker action Automated spell checking for all pull requests Nov 21, 2024
@sarthakpati sarthakpati changed the title Automated spell checking for all pull requests Added the ability to perform automated spell checking for all pull requests Nov 21, 2024
@sarthakpati sarthakpati changed the title Added the ability to perform automated spell checking for all pull requests Added the ability to perform automated spell checking Nov 21, 2024
@sarthakpati
Copy link
Collaborator

Waiting for this to merged before tagging.

@sarthakpati sarthakpati merged commit fad1e11 into master Nov 21, 2024
31 of 32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@sarthakpati sarthakpati deleted the feature/spellchecker branch November 21, 2024 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants