-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of script automation code to support variations for cm docker script #1099
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @arjunsuresh . Do you think we can move license checking outside get-cognata to the script and turn it on via meta? I think we will need to same functionality in different scripts (private ML models, Android SDK, etc) ...
Yes Grigori. That makes sense. But currently this is a prototype - we need to agree on if it'll work. We can make a license script dependency once we finalize this. |
Sure. Agree! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.