Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of script automation code to support variations for cm docker script #1099

Merged
merged 16 commits into from
Feb 9, 2024

Conversation

arjunsuresh
Copy link
Contributor

No description provided.

@arjunsuresh arjunsuresh requested a review from a team as a code owner February 9, 2024 08:29
Copy link

github-actions bot commented Feb 9, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@gfursin gfursin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arjunsuresh . Do you think we can move license checking outside get-cognata to the script and turn it on via meta? I think we will need to same functionality in different scripts (private ML models, Android SDK, etc) ...

@arjunsuresh
Copy link
Contributor Author

Hi @arjunsuresh . Do you think we can move license checking outside get-cognata to the script and turn it on via meta? I think we will need to same functionality in different scripts (private ML models, Android SDK, etc) ...

Yes Grigori. That makes sense. But currently this is a prototype - we need to agree on if it'll work. We can make a license script dependency once we finalize this.

@gfursin
Copy link
Contributor

gfursin commented Feb 9, 2024

Hi @arjunsuresh . Do you think we can move license checking outside get-cognata to the script and turn it on via meta? I think we will need to same functionality in different scripts (private ML models, Android SDK, etc) ...

Yes Grigori. That makes sense. But currently this is a prototype - we need to agree on if it'll work. We can make a license script dependency once we finalize this.

Sure. Agree!

Copy link
Contributor

@gfursin gfursin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfursin gfursin merged commit 4c8a781 into mlcommons:master Feb 9, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants