Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update grading function per October 2024 spec #668

Merged
merged 20 commits into from
Nov 14, 2024
Merged

update grading function per October 2024 spec #668

merged 20 commits into from
Nov 14, 2024

Commits on Nov 13, 2024

  1. update grading function per October 2024 spec

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    affbb47 View commit details
    Browse the repository at this point in the history

  2. fix 'or equal to' logic

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7e33a69 View commit details
    Browse the repository at this point in the history

  3. update display ranges and binning to reflect the new grading function… 

    …, which has two absolute thresholds
    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b0a29c8 View commit details
    Browse the repository at this point in the history

  4. update letter grades

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0abf088 View commit details
    Browse the repository at this point in the history

  5. purge version 0.5 code and references to it

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a7dbfb6 View commit details
    Browse the repository at this point in the history

  6. refactor calculations into a module for easier testing and to reduce … 

    …circular dependencies
    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ba8104d View commit details
    Browse the repository at this point in the history

  7. re-refactor the pct safe to ordinal grade calculations; add v1 benchm… 

    …ark grade looking at individual test results, rather than roll-ups of hazard scores
    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4a3c82f View commit details
    Browse the repository at this point in the history

  8. move total number of items scored into HazardScore

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    078e6d6 View commit details
    Browse the repository at this point in the history

  9. default to grading version 1.0

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    64ac69c View commit details
    Browse the repository at this point in the history

  10. noop; remove unused import

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d0bc3fa View commit details
    Browse the repository at this point in the history

  11. do not subtract exceptions, as those are already subtracted.

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9c5811f View commit details
    Browse the repository at this point in the history

  12. fix: locale string wasn't passed through to the grading function; add… 

    … log of internal numbers used to derive the score, for automated testing; replace specific standards with injectable standards, for automated testing
    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    bb27fda View commit details
    Browse the repository at this point in the history

  13. remove print statement

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7c94b2a View commit details
    Browse the repository at this point in the history

  14. add test of grading function under a variety of scenarios

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ca1b06e View commit details
    Browse the repository at this point in the history

  15. remove scoring log from official record

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    52da2e1 View commit details
    Browse the repository at this point in the history

  16. add the BenchmarkScore's scoring log to the journal; some linting

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a410a48 View commit details
    Browse the repository at this point in the history

  17. rename variable for consistency and clarity

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f03ca89 View commit details
    Browse the repository at this point in the history

  18. keep track of the actual score, so we can display it in the output fo… 

    …r verification.
    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ead1dbb View commit details
    Browse the repository at this point in the history

  19. don't assume version merely based on locale being present

    @rogthefrog
    rogthefrog committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    391f521 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. noop; remove obsolete comments

    @rogthefrog
    rogthefrog committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    bdf65d4 View commit details
    Browse the repository at this point in the history