Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/implement models #38

Merged
merged 4 commits into from
May 5, 2024
Merged

Feat/implement models #38

merged 4 commits into from
May 5, 2024

Conversation

kbiniek
Copy link
Collaborator

@kbiniek kbiniek commented May 5, 2024

No description provided.

@kbiniek kbiniek requested a review from mlederbauer May 5, 2024 10:59
mlederbauer
mlederbauer approved these changes May 5, 2024
View reviewed changes
Copy link
Owner

@mlederbauer mlederbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We will need to change the evaluation function to account for multilabel classification properly, and add tests to load the data properly with this confusing error of the dimensionality

Let's run black to fix

@kbiniek kbiniek force-pushed the feat/implement-models branch from 280a1fd to 1ad5626 Compare May 5, 2024 11:12
@kbiniek kbiniek merged commit eed1a8a into main May 5, 2024
1 check passed
@kbiniek kbiniek deleted the feat/implement-models branch May 5, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlederbauer mlederbauer mlederbauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbiniek @mlederbauer