Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for source mixing + Fix naming within tars. #233

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add unit test for source mixing + Fix naming within tars. #233

wants to merge 8 commits into from

Conversation

GeorgiosSmyrnis
Copy link
Collaborator

This adds a unit test for mixing sources, both with and without sampling.

This also fixes the naming scheme within tars, which could cause issues if two sequences within the same tar contained the same tokens - this would also result in the same name within the tarfile, which breaks WebDataset.

@GeorgiosSmyrnis
Copy link
Collaborator Author

This also makes the markers for sampling case insensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achalddave achalddave achalddave left review comments

@Vaishaal Vaishaal Awaiting requested review from Vaishaal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgiosSmyrnis @achalddave