Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRDL support for custom dialect definition #540

Open
Moxinilian opened this issue May 11, 2024 · 5 comments · May be fixed by #640
Open

IRDL support for custom dialect definition #540

Moxinilian opened this issue May 11, 2024 · 5 comments · May be fixed by #640
Labels
enhancement New feature or request

Comments

@Moxinilian
Copy link
Contributor

Moxinilian commented May 11, 2024

I am currently adding IRDL support for custom dialect definition to the C API, and once this has landed I'd like to add it to melior as well. Ideally a macro to generate useful Rust types from IRDL definitions would be really nice, but simply allowing to register custom dialects specified in IRDL would already be sufficient.

@Moxinilian
Copy link
Contributor Author

As an update: I have managed to make this work on my fork of melior that uses LLVM 19. I assume there is no interest in LLVM 19-only features for now, so once LLVM 19 is released and supported in melior, I'll be able to submit a PR.

@raviqqe raviqqe added the enhancement New feature or request label Jun 26, 2024
@TyrsDev
Copy link

TyrsDev commented Sep 14, 2024

This sounds excellent, @Moxinilian. I'm hoping for custom dialect support in melior soon. Do you have any resources or documentation available where I could see how this would be used in melior?

@Moxinilian
Copy link
Contributor Author

Yes, basically it's just a matter of exposing mlirLoadIRDLDialects, which takes a ModuleOp and loads any IRDL dialect defined in it.

@ProfFan
Copy link

ProfFan commented Sep 22, 2024

@edg-l
Copy link
Member

edg-l commented Dec 10, 2024

Made this in #640

raviqqe pushed a commit that referenced this issue Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants