Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ods include paths in macro, allowing for new dialects #640

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix ods include paths in macro, allowing for new dialects #640

wants to merge 5 commits into from

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Dec 10, 2024 •
edited
Loading

This fixes support for the following dialects in ODS like IRDL

Fixes #540

This pr includes #639

@edg-l edg-l mentioned this pull request Dec 10, 2024
Open
@edg-l edg-l requested a review from raviqqe December 10, 2024 15:24
@Moxinilian
Copy link
Contributor

Looks good to me for the IRDL part.

@edg-l
Copy link
Member Author

edg-l commented Dec 12, 2024 •
edited
Loading

@raviqqe what do you think? Looks like the test that fails is due to a diff because there is more stuff now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviqqe raviqqe Awaiting requested review from raviqqe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IRDL support for custom dialect definition
3 participants
@edg-l @Moxinilian @raviqqe