Return Result in accessors instead of panic
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviqqe
reviewed
Aug 18, 2023
melior/src/error.rs
Outdated
Comment on lines
76
to
78
| Self::Infallible => { | ||
| write!(formatter, "infallible") | ||
| } |
There was a problem hiding this comment.
Can we emulate type Infallible = ! as described in the std library documentation by removing this and panic on conversion?
Suggested change
| Self::Infallible => { | |
| write!(formatter, "infallible") | |
| } |
melior/src/error.rs
Outdated
| RunPass, | ||
| TypeExpected(&'static str, String), | ||
| UnknownDiagnosticSeverity(u32), | ||
| Utf8(Utf8Error), | ||
| Infallible, |
melior/src/error.rs
Outdated
|
|
||
| impl From<Infallible> for Error { | ||
| fn from(_: Infallible) -> Self { | ||
| Self::Infallible |
There was a problem hiding this comment.
Suggested change
| Self::Infallible | |
| unreachable!() |
7 tasks
|
Thank you for the changes again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously suggested in #274, I replaced the
.expectwith returning aResultin the operation accessors of ODS generated dialects.I also added some variants to the
Errorenum to support this. TheInfalliblevariant was added to allow usingTryIntoto convertAttributeinto itself, such that we avoid needing to handleAttributedifferently fromStringAttribute,IntAttribute, etc. But if you prefer, I can change the macro code to deal with this case instead, I'm honestly not a big fan of myInfalliblehack either.