Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some llvm intrinsics #331

Merged
merged 2 commits into from
Sep 29, 2023
Merged

add some llvm intrinsics #331

merged 2 commits into from
Sep 29, 2023

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Sep 28, 2023

Btw i found out about the ods, its pretty neat!

Although i haven't found these intrinsics in the ods.

@raviqqe
Copy link
Member

raviqqe commented Sep 29, 2023

Thank you for the addition of LLVM primitives!

The ODS is actually work done by @Danacus. It's still experimental but works amazingly at least for simple operations.

I'm gonna check out why their definitions are missing from TableGen files.

@raviqqe raviqqe enabled auto-merge (squash) September 29, 2023 05:43
@raviqqe raviqqe merged commit 6984569 into mlir-rs:main Sep 29, 2023
10 checks passed
@Danacus
Copy link
Contributor

Danacus commented Sep 29, 2023

I think I know why. We currently include LLVMOps.td (https://github.com/raviqqe/melior/blob/main/melior/src/dialect/ods.rs#L53), but intrinsics are defined in LLVMIntrinsicOps.td. We can either add an include line or make a separate call to dialect!.

@edg-l edg-l deleted the llvm_intr branch September 29, 2023 07:20
@raviqqe
Copy link
Member

raviqqe commented Sep 30, 2023

@Danacus Thank you for the investigation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants