Correctly propagate llvm-config errors #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, due to the extra `sh`/`cmd` indirection, if the `llvm-config` fails in the middle of the build script (say in `--libnames`), it will emit an empty `rustc-link-lib` name because the error is not propagated. The error is also not shown, and cargo will fail with a mysterious "library name must not be empty". Remove this extra indirection and improve the error messages by showing the full context if this happens. Fixes mlir-rs#45
|
@femtomc Do you recall why we had the indirection in the first place? |
|
I don't remember -- but I don't think it was for any particularly good reason. I'm in classes right now, but will re-visit when I get out today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, due to the extra
sh/cmdindirection, if thellvm-configfails in the middle of the build script (say in--libnames), it will emit an emptyrustc-link-libname because the error is not propagated. The error is also not shown, and cargo will fail with a mysterious "library name must not be empty".Remove this extra indirection and improve the error messages by showing the full context if this happens.
Fixes #45