Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full height and width to ensure that the div fills the whole element. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DrNiels
Copy link

@DrNiels DrNiels commented Feb 28, 2018

Otherwise, it was possible that percentual heights were not propagated correctly as the saw-div did not have the same height as the resize-aware element.
Also fixed the CSS style which refered to the element saw but was probably meant for the div with the id "saw"

Otherwise, it was possible that percentual heights were not propagated correctly as the saw-div did not have the same height as the resize-aware element.
Also fixed the CSS style which refered to the element saw but was probably meant for the div with the id "saw"
@mlisook
Copy link
Owner

mlisook commented Feb 28, 2018

Thank you for contributing to resize-aware.

Umm, perhaps I'm not getting this, but, one would not set the height or width of the resize-aware element itself. Constraining the resize-aware element would cause the content to spill out over the container, right?

The saw div should wrap the contents precisely to allow a scroll event to be triggered when the content size changes. It seems like one might want to set a minimum height/width on the contents, but not a hard h/w or set the same on resize-aware container, or ???

@DrNiels
Copy link
Author

DrNiels commented Jun 1, 2018

I'm sorry for responding so late.

The user can and should layout the height and width of the resize-aware element according to his own preferences. The saw div however, is contained within the resize-aware element and should fill the element completely, which is why I set the height and width to 100%.

Currently, for example, when you style the element to have 50% height, the div saw could have a different height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants