feat: offset column role in Task #1225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebffischer
reviewed
Jan 24, 2025
| stopf("Offset column(s) %s must be a numeric or integer column", paste0("'", new_roles[["offset"]], "'", collapse = ",")) | ||
| } | ||
|
|
||
| if (any(task$missings(cols = new_roles[["offset"]]) > 0)) { |
There was a problem hiding this comment.
Maybe use a shorter circuit (something like mlr3misc::some)
There was a problem hiding this comment.
I would use vectorization when available, so the version here is fine i'd say (?)
bblodfon
commented
Jan 31, 2025
| @@ -4,10 +4,12 @@ | |||
| #' The following properties are currently standardized and understood by learners in \CRANpkg{mlr3}: | |||
| #' * `"missings"`: The learner can handle missing values in the data. | |||
| #' * `"weights"`: The learner supports observation weights. | |||
| #' * `"offset"`: The learner can incorporate offset values to adjust predictions. | |||
| #' * `"importance"`: The learner supports extraction of importance scores, i.e. comes with an `$importance()` extractor function (see section on optional extractors in [Learner]). | |||
There was a problem hiding this comment.
@be-marc here hotstart_forward, hotstart_backward and featureless are not documented, but they should be perhaps?
be-marc
reviewed
Feb 6, 2025
| #' * `"offset"`: Offset values specifying fixed adjustments for model training. | ||
| #' These values can be used to provide baseline predictions from an existing model for updating another model. | ||
| #' Some learners require an offset for each target class in a multiclass setting. | ||
| #' In this case, the offset columns must be named `"offset_{target_class_name}"`. | ||
| #' |
be-marc
reviewed
Feb 6, 2025
| #' * `"offset"`: Offset values specifying fixed adjustments for model training. | ||
| #' These values can be used to provide baseline predictions from an existing model for updating another model. | ||
| #' Some learners require an offset for each target class in a multiclass setting. | ||
| #' In this case, the offset columns must be named `"offset_{target_class_name}"`. | ||
| #' |
There was a problem hiding this comment.
Simple models just shift the prediction. And add link to learners.
be-marc
reviewed
Feb 6, 2025
| task$col_roles$offset = character() | ||
| expect_true("offset" %nin% task$properties) | ||
| expect_null(task$offset) | ||
| }) |
mb706
reviewed
Feb 6, 2025
| return(NULL) | ||
| } | ||
|
|
||
| self$backend$data(private$.row_roles$use, offset_cols) |
There was a problem hiding this comment.
maybe setnames() or sanitize in some other way, as we do in the other ABs
be-marc
reviewed
Feb 6, 2025
| return(NULL) | ||
| } | ||
|
|
||
| self$backend$data(private$.row_roles$use, offset_cols) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offsetfor mlr3 learnersxgboostinmlr3learnersuses this now mlr3learners PR