feat: as_callbacks returns named list (#125)

NEWS.md

@@ -1,5 +1,7 @@
 # mlr3misc (development version)
 
+* feat: `as_callbacks()` returns a list named by the callback ids now.
+
 # mlr3misc 0.16.0
 
 * fix: `crate()` is using the correct 'topenv' environment now.

R/Callback.R

@@ -145,13 +145,14 @@ as_callbacks.NULL = function(x, ...) { # nolint
 #' @rdname as_callback
 #' @export
 as_callbacks.list = function(x, clone = FALSE, ...) { # nolint
-  lapply(x, as_callback, clone = clone, ...)
+  callbacks = lapply(x, as_callback, clone = clone, ...)
+  set_names(callbacks, map(callbacks, "id"))
 }
 
 #' @rdname as_callback
 #' @export
 as_callbacks.Callback = function(x, clone = FALSE, ...) { # nolint
-  list(if (clone) x$clone(deep = TRUE) else x)
+  set_names(list(if (clone) x$clone(deep = TRUE) else x), x$id)
 }
 
 #' @title Call Callbacks

tests/testthat/test_Callback.R

@@ -89,8 +89,6 @@ test_that("call_back() function works", {
   expect_equal(context$d, 1)
 })
 
-
-
 test_that("as_callbacks.Callback works", {
   CallbackTest  = R6Class("CallbackTest",
     inherit = Callback,
@@ -104,4 +102,10 @@ test_that("as_callbacks.Callback works", {
   test_callback = CallbackTest$new(id = "mlr3misc.test", label = "Test Callback", man = "mlr3misc::Callback")
 
   expect_list(as_callbacks(test_callback))
+  expect_names(names(as_callbacks(test_callback)), identical.to = "mlr3misc.test")
+
+  test_callback_2 = CallbackTest$new(id = "mlr3misc.test_2", label = "Test Callback", man = "mlr3misc::Callback")
+
+  expect_list(as_callbacks(list(test_callback, test_callback_2)))
+  expect_names(names(as_callbacks(list(test_callback, test_callback_2))), identical.to = c("mlr3misc.test", "mlr3misc.test_2"))
 })