Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CPU and allow users to load local files #11

Merged
merged 24 commits into from
Nov 20, 2024

Conversation

GiladShapira94
Copy link
Contributor

This PR should fix and support cpu for running this demo and using local files

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@guy1992l guy1992l changed the title [Demos} Support CPU and allow users to load local files Support CPU and allow users to load local files Nov 18, 2024
Copy link
Collaborator

@yonishelach yonishelach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!
I added also comments in the notebook so please take a look in there as well

@@ -54,13 +54,13 @@
"execution_count": null,
Copy link
Collaborator

@yonishelach yonishelach Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.        name="call-center-demo-test",

remove -test from name


Reply via ReviewNB

@@ -54,13 +54,13 @@
"execution_count": null,
Copy link
Collaborator

@yonishelach yonishelach Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #6.        display(Markdown("You chooce to load the data from your local storage, you can skip the calls generation and move to [calls analysis](#calls_analysis)"))

Typo in the word chooce -> choose


Reply via ReviewNB

@yonishelach yonishelach merged commit 3a3ddae into mlrun:main Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants