v2 #4
Merged
v2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
guy1992l
requested changes
Jan 30, 2024
| raise EnvironmentError( | ||
| f"One or more of the OpenAI required environment variables ('{key}', '{base}') are missing." | ||
| f"Please set them as environment variables or install mlrun (`pip install mlrun`)" | ||
| f"and set them as project secrets using `projecy.set_secrets`." |
There was a problem hiding this comment.
Suggested change
| f"and set them as project secrets using `projecy.set_secrets`." | |
| f"and set them as project secrets using `project.set_secrets`." |
| def _set_openai_secrets() -> bool: | ||
| key = "OPENAI_API_KEY" | ||
| base = "OPENAI_API_BASE" | ||
| # Check if the key is already in the environment variables: |
There was a problem hiding this comment.
Suggested change
| # Check if the key is already in the environment variables: | |
| # Check if the key is already in the environment variables: |
| # Check if the key is already in the environment variables: | ||
| if key in os.environ and base in os.environ: | ||
| return True | ||
| # Check if mlrun is installed: |
There was a problem hiding this comment.
Suggested change
| # Check if mlrun is installed: | |
| # Check if mlrun is installed: |
| audio = resampler(audio) | ||
| # Save to audio file: | ||
| audio_file = output_directory / f"{text_file.stem}.{file_format}" | ||
|
|
| else: | ||
| audio_pieces["all"] += [audio, gap_between_speakers] | ||
| # Construct a single audio array from all the pieces and channels: | ||
|
|
| - The generated audio files dataframe. | ||
| - The errors dictionary. | ||
| """ | ||
|
|
|
|
||
| global _LOGGER | ||
| _LOGGER = _get_logger() | ||
| # Get the input text files to turn to audio: |
There was a problem hiding this comment.
Suggested change
| # Get the input text files to turn to audio: | |
| # Get the input text files to turn to audio: |
| format=file_format, | ||
| bits_per_sample=bits_per_sample, | ||
| ) | ||
|
|
Comment on lines
+23
to
+38
| def pipeline( | ||
| amount: int, | ||
| generation_model: str, | ||
| use_small_models: bool, | ||
| language: str, | ||
| available_voices: List[str], | ||
| min_time: int, | ||
| max_time: int, | ||
| from_date: str, | ||
| to_date: str, | ||
| from_time: str, | ||
| to_time: str, | ||
| num_clients: int, | ||
| num_agents: int, | ||
| generate_clients_and_agents: bool = True, | ||
| ): |
There was a problem hiding this comment.
where all the doc strings went? I'm sure I wrote them, weird 😕
There was a problem hiding this comment.
I did not see them anywhere... maybe you wrote them locally?
Comment on lines
+99
to
+109
| def pipeline( | ||
| batch: str, | ||
| calls_audio_files: str, | ||
| transcribe_model: str, | ||
| translate_to_english: bool, | ||
| pii_recognition_model: str, | ||
| pii_recognition_entities: List[str], | ||
| pii_recognition_entity_operator_map: List[str], | ||
| question_answering_model: str, | ||
| batch_size: int = 2, | ||
| ): |
guy1992l
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.