Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo edits #6

Merged
merged 2 commits into from
Mar 7, 2024
Merged

demo edits #6

merged 2 commits into from
Mar 7, 2024

Conversation

jillnogold
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@guy1992l guy1992l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent Jill! Just 2 comments:

  • If you change the tag usage in the table of contents (example: from #project_creation to create-the-project) you must change the tag itself. This is what links the anchors in the notebook. See this: <a id="project_creation"></a> at the top of every section, this should be renamed as well. More so, I think tags do not support dashes (-) so use underscores (_).
  • Under section 2. there is a tiny hiccup generatedand :
    2. Generate the call data
    
    > Note: This entire workflow can be skipped if you want to use data that is  already 
    generatedand  available in this demo. See the [next cell]. 
    

@jillnogold
Copy link
Member Author

I think - and _ both work, but changed to _ nevertheless.
All updates implemented

@guy1992l guy1992l merged commit 31d71f3 into mlrun:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants