Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storey distribution - don't include tests/integration in packages #534

Merged
merged 18 commits into from
Sep 8, 2024
Merged

Fix storey distribution - don't include tests/integration in packages #534

merged 18 commits into from
Sep 8, 2024

Conversation

jond01
Copy link
Member

@jond01 jond01 commented Sep 4, 2024 •
edited by jira bot
Loading

Fixes ML-7758.

In addition:

  • General Docker cleaning
  • Add a proper .gitignore file
  • Fix Python support labels and requirement in the distribution

@jond01 jond01 requested a review from gtopper September 4, 2024 14:08
gtopper
gtopper requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup 🙂. As mentioned below, gitignore is not check in on purpose. Other than that and .python-version, it looks good.

tomerm-iguazio
tomerm-iguazio requested changes Sep 8, 2024
View reviewed changes
tomerm-iguazio
tomerm-iguazio requested changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@tomerm-iguazio tomerm-iguazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need to add few paths to gitignore according to makefile :)

tomerm-iguazio
tomerm-iguazio approved these changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@tomerm-iguazio tomerm-iguazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good:)

@gtopper gtopper merged commit d36945a into mlrun:development Sep 8, 2024
3 checks passed
@jond01 jond01 deleted the fix/storey-distribution branch September 8, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtopper gtopper gtopper approved these changes

@tomerm-iguazio tomerm-iguazio tomerm-iguazio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jond01 @gtopper @tomerm-iguazio