This repository has been archived by the owner on Aug 28, 2019. It is now read-only.
Improve Twitter cards & Open Graph tags. #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following issues: __*Issue 1:*__ Twitter cards require the ':site' tag. > twitter:site > @username of website. Either twitter:site or twitter:site:id is required. Ref: https://dev.twitter.com/cards/markup The `site` tag is supposed to be used for the site specific twitter account, the `creator` tag for the twitter account of the author or the article. Adding a config variable for the site twitter account to account for this. Twitter tags will be shown if either (site.twitter or site.owner.twitter) is available. Both tags will fall back to each other. __*Issue 2:*__ Twitter cards will automatically fall back to Open graph tags if available, so we can remove the Twitter specific title and description tags as those are duplicated in the open graph tags. Also, the OG tags did not have the image tag while twitter did, so moving those from twitter to OG, to make them available to both. Ref: https://dev.twitter.com/cards/getting-started#opengraph __*Issue 3:*__ Not all sites are written in US english. Adding a config variable to set the locale of a site.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues:
Issue 1:
Twitter cards require the ':site' tag.
Ref: https://dev.twitter.com/cards/markup
The
sitetag is supposed to be used for the site specific twitter account, thecreatortag for the twitter account of the author or the article.Adding a config variable for the site twitter account to account for this.
Twitter tags will be shown if either (
site.twitterorsite.owner.twitter) is available.Both tags will fall back to each other.
Issue 2:
Twitter cards will automatically fall back to Open graph tags if available, so we can remove the Twitter specific title and description tags as those are duplicated in the open graph tags.
Also, the OG tags did not have the image tag while twitter did, so moving those from twitter to OG, to make them available to both.
Ref: https://dev.twitter.com/cards/getting-started#opengraph
Issue 3:
Not all sites are written in US english.
Adding a config variable to set the locale of a site.