Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double import if using import type #396

Merged
merged 1 commit into from
May 24, 2022
Merged

fix: double import if using import type #396

merged 1 commit into from
May 24, 2022

Conversation

antonmihaylov
Copy link
Contributor

Made a small fix for a particular use case. No breaking changes, the usual import statement is imported as it was before

What's changed

  • When using typegen allow having import type * as queries and import type queries in the ts file

Why

If using type-only imports (especially if configured automatically with @typescript-eslint/consistent-type-imports) the types get doubled when running the generator

image

@codecov-commenter
Copy link

Codecov Report

Merging #396 (918081c) into master (f761e93) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files          32       32           
  Lines        1151     1152    +1     
  Branches      222      218    -4     
=======================================
+ Hits         1114     1115    +1     
  Misses         33       33           
  Partials        4        4           
Impacted Files Coverage Δ
packages/typegen/src/write/inline.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f761e93...918081c. Read the comment docs.

@mmkal mmkal merged commit c7ace0c into mmkal:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants