Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove sizeclasses v1.9.2+rai #41

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix/remove sizeclasses v1.9.2+rai #41

merged 2 commits into from
Feb 28, 2024

Conversation

udesou
Copy link

@udesou udesou commented Feb 28, 2024

No description provided.

@udesou udesou requested a review from qinsoon February 28, 2024 04:31
@udesou udesou merged commit 09e025b into mmtk:v1.9.2+RAI Feb 28, 2024
2 checks passed
udesou pushed a commit to udesou/julia that referenced this pull request Aug 19, 2024
@topolarity @JeffBezanson
improve inference of CPU_THREADS in Sys.__init__ (JuliaLang#54384)
99bda02 
Without this change, the compiler fails to notice that `env_threads isa
Int` in the fall-through case, leading to a union-split with a branch
that is in fact unreachable:

```
43 ┄ %109 = φ (mmtk#41 => %105, mmtk#42 => %108)::Union{Nothing, Int64}
│    %110 = (%109 isa Int64)::Bool
└───        goto mmtk#45 if not %110
...
45 ─ %126 = π (%109, Nothing)
│           Base.convert(Int64, %126)::Union{}
└───        unreachable
```

After this change, the union-split is eliminated.

Co-authored-by: Jeff Bezanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon Awaiting requested review from qinsoon

Assignees
No one assigned
Labels
port-to-master port-to-v1.9 port-to-v1.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@udesou