Skip to content

Remove V8 tests from extended tests #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented May 1, 2025

This PR removes V8 tests from our extended tests for mmtk-core. The V8 version we use in the binding is outdated, and the required environments are no longer supported by Github runners. See the discussion in #ANU Research > The V8 binding is beyond repair @ 💬.

@qinsoon qinsoon added the PR-extended-testing Run extended tests for the pull request label May 1, 2025
@qinsoon qinsoon requested review from udesou and wks May 1, 2025 05:55
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue May 8, 2025
Merged via the queue into mmtk:master with commit df7a1f1 May 8, 2025
38 checks passed
@qinsoon qinsoon deleted the remove-v8-test branch May 8, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-extended-testing Run extended tests for the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants