experiment: diod di container #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnahkies
commented
Oct 14, 2024
| builder.registerAndUse(ReferenceManager) | ||
|
|
||
| builder.registerAndUse(GroupsRepository) | ||
| builder.register(IdpAdapter).use(FirebaseAuthService).asSingleton() |
There was a problem hiding this comment.
This is hacky, just to get the POC to work. It's to avoid re-initializing the firebase SDK, which throws an error. Should be refactored.
mnahkies
commented
Oct 14, 2024
mnahkies
commented
Oct 14, 2024
| builder.registerAndUse(GroupsRepository) | ||
| builder.register(IdpAdapter).use(FirebaseAuthService).asSingleton() | ||
|
|
||
| builder.register(UsersImplementation).use(UsersHandlers) |
There was a problem hiding this comment.
One thing I don't like about this is that it would seem to make it difficult inject things scoped/initialized with contextual configuration per request. Need experiment more with diod to figure out the best patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playing around with using diod as a dependency injection container, using the changes from mnahkies/openapi-code-generator#256
notes:
import typedoesn't work withdiod- removes the information it uses for auto-wiring I guesstsxalso won't work withdiodsince it bypasses the typescript compiler