[CI] Fix pytest warnings being raised on CI (#169)

* Fix ci

Signed-off-by: Adam Li <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix pre-commit

Signed-off-by: Adam Li <[email protected]>

* Fix unit-tests

Signed-off-by: Adam Li <[email protected]>

* improve style and run stubgen

* avoid shadowing of builtin

* fix tests and pin pytest to 8.0 or above

* fix ruff configuration deprecation warnings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Adam Li <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: mscheltienne <[email protected]>

mne_icalabel/datasets/icalabel/icalabel.py

@@ -42,7 +42,7 @@ def data_path(
     download : bool
         If False and the dataset has not been downloaded yet,
         it will not be downloaded and the path will be returned
-        as ‘’ (empty string). This is mostly used for debugging purposes
+        as ``‘’`` (empty string). This is mostly used for debugging purposes
         and can be safely ignored by most users.
     %(verbose)s
 

mne_icalabel/datasets/icalabel/icalabel.pyi

@@ -30,7 +30,7 @@ def data_path(
     download : bool
         If False and the dataset has not been downloaded yet,
         it will not be downloaded and the path will be returned
-        as ‘’ (empty string). This is mostly used for debugging purposes
+        as ``‘’`` (empty string). This is mostly used for debugging purposes
         and can be safely ignored by most users.
 
     verbose : bool | str | int | None

mne_icalabel/iclabel/tests/test_label_components.py

@@ -124,14 +124,14 @@ def test_warnings():
         random_state=101,
     )
     ica.fit(raw)
-    with pytest.warns(RuntimeWarning, match="common average reference"):
+    with pytest.warns(RuntimeWarning, match="common average reference"), pytest.warns(
+        RuntimeWarning, match="not filtered between 1 and 100 Hz"
+    ):
         iclabel_label_components(raw, ica)
-    with pytest.warns(RuntimeWarning, match="not filtered between 1 and 100 Hz"):
-        iclabel_label_components(raw, ica)
-
     with raw.info._unlock():
         raw.info["lowpass"] = 100.0
     raw.set_eeg_reference("average")
+
     # infomax
     ica = ICA(
         n_components=3,

pyproject.toml

@@ -118,8 +118,8 @@ test = [
   'pandas',
   'pymatreader',
   'PyQt6',
-  'pytest',
   'pytest-cov',
+  'pytest>=8.0.0',
 ]
 torch = [
   'torch',
@@ -185,22 +185,24 @@ match-dir = '^mne_icalabel.*'
 [tool.pytest.ini_options]
 addopts = '--durations 20 --junit-xml=junit-results.xml -v --color=yes'
 junit_family = 'xunit2'
-minversion = '6.0'
+minversion = '8.0'
 
 [tool.ruff]
 extend-exclude = [
   'doc',
   'setup.py',
 ]
-ignore = []
 line-length = 88
-select = ["E", "F", "UP", "W"]
 target-version = 'py39'
 
 [tool.ruff.format]
 docstring-code-format = true
 
-[tool.ruff.per-file-ignores]
+[tool.ruff.lint]
+ignore = []
+select = ["E", "F", "UP", "W"]
+
+[tool.ruff.lint.per-file-ignores]
 '*' = [
   "UP007", # 'Use `X | Y` for type annotations', requires python 3.10
 ]

tools/stubgen.py

@@ -63,5 +63,5 @@
     isort.file(stub, config=config_isort)
 
 # run ruff to improve stub style
-exec = subprocess.run(["ruff", "format", str(directory), "--config", config])
-sys.exit(exec.returncode)
+execution = subprocess.run(["ruff", "format", str(directory), "--config", config])
+sys.exit(execution.returncode)