Added a TODO to start implementation of HED support in annotations #13059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
drammock
force-pushed
the
hed-annotations
branch
from
1d5fa0b to
c31e837
Compare
drammock
reviewed
Jan 13, 2025
| ch_names=None, | ||
| ): | ||
| hed = _soft_import("hedtools", "validation of HED tags in annotations") # noqa | ||
| # TODO is some sort of initialization of the HED cache directory necessary? |
| orig_time=orig_time, | ||
| ch_names=ch_names, | ||
| ) | ||
| # TODO validate the HED version the user claims to be using. |
| f"Number of HED tags ({len(hed_tags)}) must match the number of " | ||
| f"annotations ({len(self)})." | ||
| ) | ||
| # TODO insert validation of HED tags here |
Comment on lines
+876
to
+896
| def append(self, onset, duration, description, ch_names=None): | ||
| """TODO.""" | ||
| pass | ||
|
|
||
| def count(self): | ||
| """TODO. Unlike Annotations.count, keys should be HED tags not descriptions.""" | ||
| pass | ||
|
|
||
| def crop( | ||
| self, tmin=None, tmax=None, emit_warning=False, use_orig_time=True, verbose=None | ||
| ): | ||
| """TODO.""" | ||
| pass | ||
|
|
||
| def delete(self, idx): | ||
| """TODO.""" | ||
| pass | ||
|
|
||
| def to_data_frame(self, time_format="datetime"): | ||
| """TODO.""" | ||
| pass |
There was a problem hiding this comment.
@VisLab these TODOs are for me. So as you can see some things aren't going to work yet, but we're already at least able to do:
$ ipython
In [1]: import mne
In [2]: foo = mne.HEDAnnotations([0, 1], [0.5, 1.2], ['foo', 'bar'], ['hed/foo', 'hed/
...: bar'])
In [3]: foo
Out[3]: <HEDAnnotations | 2 segments: hed/bar (1), hed/foo (1)>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #11519
Added a TODO to annotations.py as agreed to get started on implementation of basic-level HED (Hierarchical Event Descriptors) support in mne annotations to allow HED tags to be used in epoching.