Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG, BUG: Fix Epochs for latest MNE #22

Merged
merged 21 commits into from
Feb 10, 2021
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Feb 8, 2021

Closes #21.

Todo:

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #22 (995ccb8) into master (9789193) will increase coverage by 36.60%.
The diff coverage is 78.26%.

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage   34.18%   70.78%   +36.60%     
===========================================
  Files          15       15               
  Lines        1606     1633       +27     
  Branches      198      203        +5     
===========================================
+ Hits          549     1156      +607     
+ Misses       1045      415      -630     
- Partials       12       62       +50     

@larsoner
Copy link
Member Author

larsoner commented Feb 8, 2021

CircleCI will be broken until we figure out a way to handle labstreaminglayer/pylsl#42. We can work around it using subprocess probably but it'll be a bit ugly.

@jasmainak
Copy link
Member

Thanks a lot Eric. I can look into it after 12th. In the meanwhile perhaps @teonbrooks can review/try out the PR?

@larsoner larsoner changed the title WIP, BUG: Fix Epochs for latest MNE MRG, BUG: Fix Epochs for latest MNE Feb 9, 2021
Copy link
Member Author

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream PR is merged so this should be good to go

environment.yml Outdated Show resolved Hide resolved
Copy link
Member

@teonbrooks teonbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and glad to see that the multiprocessing is also addressed. I left a few comments more out of clarification

doc/conf.py Show resolved Hide resolved
mne_realtime/epochs.py Show resolved Hide resolved
mne_realtime/tests/test_mock_client.py Outdated Show resolved Hide resolved
@teonbrooks teonbrooks merged commit 641d137 into mne-tools:master Feb 10, 2021
@teonbrooks
Copy link
Member

thanks @larsoner!

@larsoner larsoner deleted the fixes branch February 10, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mne_realtime.RtEpochs always returning an AssertionError
3 participants