-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG, BUG: Fix Epochs for latest MNE #22
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
===========================================
+ Coverage 34.18% 70.78% +36.60%
===========================================
Files 15 15
Lines 1606 1633 +27
Branches 198 203 +5
===========================================
+ Hits 549 1156 +607
+ Misses 1045 415 -630
- Partials 12 62 +50 |
CircleCI will be broken until we figure out a way to handle labstreaminglayer/pylsl#42. We can work around it using |
Thanks a lot Eric. I can look into it after 12th. In the meanwhile perhaps @teonbrooks can review/try out the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream PR is merged so this should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and glad to see that the multiprocessing is also addressed. I left a few comments more out of clarification
thanks @larsoner! |
Closes #21.
Todo: