Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement Style API Docs #201

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Conversation

LoayTarek5
Copy link

Description

#133

Related Issues

This PR Fix the API documentation, Now the titles of response are easy to read and noticeable by adding some space, change color and add border left

How can it be tested?

N/A

Impacted packages

Check the NPM packages that require a new publication or release:

Check list before submitting

  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR
  • This PR is wrote in a clear language and correctly labeled

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
manifest-schema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 7:53am

Copy link
Contributor

@SebConejo SebConejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LoayTarek5 This time the code works. Viewing the result I have some suggestions. As you chose a vibrant color, I think we don't need anymore the small border and padding-left. Could you remove it ?

It works well without and the design is more consistent.
Capture d’écran 2024-10-04 à 10 27 36

@brunobuddy
Copy link
Contributor

@LoayTarek5 @SebConejo thank you for your work !

The failing tests were because of some regression. You can merge the last develop version in this branch and it should pass.

However those PRs should be done on the develop branch as explained on the contributing file. The title says "fix" but I see it more as an visual enhancement than a bug fix.

Cheers !

@LoayTarek5 LoayTarek5 changed the base branch from master to develop October 7, 2024 05:25
@LoayTarek5 LoayTarek5 changed the title Fix Style API Docs enhancement Style API Docs Oct 7, 2024
@LoayTarek5
Copy link
Author

@brunobuddy I changed the base branch from master to develop
is that right?

@brunobuddy
Copy link
Contributor

@LoayTarek5 yes and now you can merge the develop branch in yours to update the tests.

@LoayTarek5
Copy link
Author

@brunobuddy"Am I finished?"

@SebConejo SebConejo self-assigned this Oct 28, 2024
@SebConejo SebConejo self-requested a review October 28, 2024 09:46
@brunobuddy brunobuddy merged commit 92959a4 into mnfst:develop Nov 15, 2024
4 checks passed
@brunobuddy
Copy link
Contributor

@LoayTarek5 good job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants