Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cleanup remove empty interface #202

Closed

Conversation

imkeanserna
Copy link

Description

This pull request is for issue #176 removes the ValidationManifest.ts file due to its empty interface, which was equivalent to its supertype. All instances using ValidationManifest have been updated to directly use ValidationSchema instead.

Related Issues

N/A

How can it be tested?

  1. You can just run the existing unit and integration tests to ensure no breaking changes.
  2. Test the API endpoints that require a 403 Forbidden response to confirm that the response format remains consistent after refactoring.
  3. Optionally, manually invoke any API endpoints related to manifest or entity manifest to make sure it's proper.

Check list before submitting

  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR
  • This PR is wrote in a clear language and correctly labeled

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
manifest-schema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 1:19pm

@brunobuddy
Copy link
Contributor

@imkeanserna thank you for your contribution but I will not be able to accept it as this interface is going to be filled later.

Your PR is perfect, it is just that this issue is not relevant as we are going to build upon it. Sorry for the inconvenience.

@brunobuddy brunobuddy closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants