-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👋 Onboarding first admin #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor: Extracted isDbEmpty guard logic in new database service
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SebConejo
approved these changes
Nov 4, 2024
Ok for me 👍 @brunobuddy fyi, Here is the page after styling it : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a "Register first admin" page for the first launch if the DB is empty.
@SebConejo some styling is needed for the "register first admin" page.
How can it be tested?
/manifest/packages/core/manifest/manifest/backend.db
filenpm run dev
You will be redirected to the
/auth/welcome
page to create a new admin. Follow the instructions.Ensure that you cannot go to that page again after admin creation.
To repeat to tests, delete again the backend.db file and restart the npm run dev task
Impacted packages
Check the NPM packages that require a new publication or release:
Check list before submitting