Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed old twitter logo to new #32

Closed
wants to merge 1 commit into from

Conversation

nitesh2920
Copy link

@nitesh2920 nitesh2920 commented Oct 23, 2024

Description

The Twitter icon chage to new X icon

closes #30

Check list before submitting

  • If this PR added new pages, they have been added to the sitemap and their metadata is clear and optimized
  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • [] I updated the documentation if necessary
  • This PR is wrote in a clear language and correctly labeled

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
manifest-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 7:28pm

Copy link
Collaborator

@brunobuddy brunobuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nitesh2920

Thank you for your contribution !

The "X" logo is a bit bigger that the one next to it. Can you adapt the size ?

@nitesh2920
Copy link
Author

Hello @nitesh2920

Thank you for your contribution !

The "X" logo is a bit bigger that the one next to it. Can you adapt the size ?

okay! I have try taht but getting bit difficulty as because using svg and rest icons are from library so this size seems to be a slighty better that's why I raise a PR for it , but it's okay I will try once again
@brunobuddy

@SebConejo
Copy link
Collaborator

This section has been removed from the website so I close the pr that contained requested changes

@SebConejo SebConejo closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Update Twitter Logo to New "X" Logo
3 participants