Improved fault debugging for ramp meter algorithm

mnit-rtmc · Jan 23, 2025 · 789f0d3 · 789f0d3
1 parent 8317360
commit 789f0d3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/src/us/mn/state/dot/tms/server/KAdaptiveAlgorithm.java b/src/us/mn/state/dot/tms/server/KAdaptiveAlgorithm.java
@@ -365,8 +365,14 @@ private R_NodeImpl findRNode(RampMeterImpl meter) {
 			Corridor cor =
 				BaseObjectImpl.corridors.getCorridor(cid);
 			if (cor != null) {
-				return cor.findActiveNode(
+				R_NodeImpl n = cor.findActiveNode(
 					new ForkFinder(rnode));
+				if (null == n && ALG_LOG.isOpen()) {
+					log("Fork not found " +
+						rnode.getName() + " for " +
+						meter.getName());
+				}
+				return n;
 			}
 		}
 		return rnode;

diff --git a/src/us/mn/state/dot/tms/server/RampMeterImpl.java b/src/us/mn/state/dot/tms/server/RampMeterImpl.java
@@ -559,16 +559,23 @@ private MeterAlgorithmState createState() {
 		case SIMPLE:
 			return new SimpleAlgorithm();
 		case K_ADAPTIVE:
-			MeterAlgorithmState as =
-				KAdaptiveAlgorithm.meterState(this);
-			if (null == as)
-				updateFault(RampMeterFault.MISSING_STATE);
-			return as;
+			return createKAdaptiveState();
 		default:
 			return null;
 		}
 	}
 
+	/** Create K-Adaptive algorithm state */
+	private MeterAlgorithmState createKAdaptiveState() {
+		MeterAlgorithmState as = null;
+		if (ent_node != null) {
+			as = KAdaptiveAlgorithm.meterState(this);
+			if (null == as)
+				updateFault(RampMeterFault.MISSING_STATE);
+		}
+		return as;
+	}
+
 	/** Validate the metering algorithm */
 	public void validateAlgorithm() {
 		MeterAlgorithmState s = alg_state;