Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Mechanism for Deployment Requests #193

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

movchan74
Copy link
Contributor

Summary:
This PR implements retry logic to ensure deployment requests are retried upon failure, addressing the issue of one-time request attempts that do not retry on failure.

Key Changes:

  1. Retry Logic Added to Deployment Requests: Introduced a retry mechanism with configurable parameters such as the number of retries, delay between retries, and specific exceptions that can trigger a retry.

  2. Exponential Backoff with Jitter: Integrated sleep_exponential_backoff for delays between retries, applying full jitter to reduce the chances of synchronized retry requests.

  3. Tests for Retry Mechanism: Added unit tests to validate the retry functionality.

@movchan74 movchan74 added enhancement New feature or request Reliability Aana is designed to be reliable and robust. It is built to be fault-tolerant and to handle failures labels Oct 29, 2024
@movchan74 movchan74 requested a review from HRashidi October 29, 2024 15:19
@movchan74 movchan74 self-assigned this Oct 29, 2024
Copy link
Contributor

@HRashidi HRashidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

aana/utils/core.py Outdated Show resolved Hide resolved
@movchan74 movchan74 requested a review from HRashidi October 30, 2024 11:43
Copy link
Contributor

@HRashidi HRashidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@movchan74 movchan74 merged commit 94ed700 into main Oct 30, 2024
6 checks passed
@movchan74 movchan74 deleted the deployment_request_retry branch October 30, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Reliability Aana is designed to be reliable and robust. It is built to be fault-tolerant and to handle failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants