Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sampling Parameters Merging #206

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Fix Sampling Parameters Merging #206

merged 5 commits into from
Nov 21, 2024

Conversation

movchan74
Copy link
Contributor

Refactor the merged_options function to exclude unset fields and improve handling of unset sampling parameters in deployments.

@movchan74 movchan74 marked this pull request as ready for review November 21, 2024 10:07
appoose
appoose approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@appoose appoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it per se. But good to go looking at code logic.

appoose
appoose approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@appoose appoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have not tested it. But looks gtg.

@movchan74 movchan74 merged commit a45d79e into main Nov 21, 2024
5 of 6 checks passed
@movchan74 movchan74 deleted the merge_options_bug_fix branch November 28, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appoose appoose appoose approved these changes

@HRashidi HRashidi Awaiting requested review from HRashidi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@movchan74 @appoose