Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error handling in global fixtures #5208 #5275

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

fix: improve error handling in global fixtures #5208 #5275

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b9874b5
fix: improve error handling in global fixtures #5208
TG199 Dec 19, 2024
bc63cb0
remove test file
TG199 Dec 19, 2024
f0d9524
Update lib/mocha.js
TG199 Jan 3, 2025
ae2c3a3
mark failed test
TG199 Jan 3, 2025
2319487
create false hook to represent global teardown failure
TG199 Jan 31, 2025
4649a6a
Add test
TG199 Jan 31, 2025
041536d
correct assertion
TG199 Jan 31, 2025
d6ff7cc
fix test file path, correct global teardown type
TG199 Jan 31, 2025
b00630c
Changes:
TG199 Feb 5, 2025
848f6a7
Add tests
TG199 Feb 6, 2025
2731673
Mark failed test:
TG199 Feb 7, 2025
38dfe9b
exit with code 1
TG199 Feb 7, 2025
a026f9d
refactor: pass 'phase' as an argument to _runGlobalFixtures
TG199 Feb 19, 2025
f8ddf9c
chore: document phase parameters for _runGlobalFixtures
TG199 Feb 20, 2025
6c380e5
fix: correct test expectations for _runGlobalFixtures in mocha.spec.js
TG199 Feb 20, 2025
a22ea8a
test: rename global-teardown-errors.spec.js to global-fixtures.spec.j…
TG199 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/mocha.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ Mocha.prototype.failZero = function (failZero) {
* @return {Mocha} this
* @chainable
*/
Mocha.prototype.passOnFailingTestSuite = function(passOnFailingTestSuite) {
Mocha.prototype.passOnFailingTestSuite = function (passOnFailingTestSuite) {
this.options.passOnFailingTestSuite = passOnFailingTestSuite === true;
return this;
};
Expand Down Expand Up @@ -1219,7 +1219,7 @@ Mocha.prototype.runGlobalTeardown = async function runGlobalTeardown(
};

/**
* Run global fixtures sequentially with context `context`
* Run global fixtures sequentially with context `context`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some unrelated changes: a blank line above, this ., an extra , later, etc. - https://www.joshuakgoldberg.com/blog/split-out-unrelated-changes -> https://www.joshuakgoldberg.com/blog/split-out-unrelated-changes/#separate-logical-and-stylistic-changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG199 this piece of feedback is still open

* @private
* @param {MochaGlobalFixture[]} [fixtureFns] - Fixtures to run
* @param {object} [context] - context object
Expand All @@ -1229,8 +1229,12 @@ Mocha.prototype._runGlobalFixtures = async function _runGlobalFixtures(
fixtureFns = [],
context = {}
) {
for await (const fixtureFn of fixtureFns) {
await fixtureFn.call(context);
for (const fixtureFn of fixtureFns) {
try {
await fixtureFn.call(context);
} catch (err) {
console.error(err.stack);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Functionality] This is a good start, but I think we'll want to do more than just log the error to the console. I think we'll want to mark the test as failed too. It's easy to miss console logs that don't change the exit code.

}
}
return context;
};
Expand Down
Loading