Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin wandb version in llm-finetuning repo #46

Closed
wants to merge 4 commits into from
Closed

Pin wandb version in llm-finetuning repo #46

wants to merge 4 commits into from

Conversation

yirenlu92
Copy link
Contributor

@yirenlu92 yirenlu92 commented Apr 18, 2024 •
edited
Loading

@yirenlu92 yirenlu92 changed the title Update llm-finetuning docs Pin wandb version in llm-finetuning repo Apr 18, 2024
@yirenlu92 yirenlu92 requested a review from mwaskom April 18, 2024 23:12
@mwaskom
Copy link
Collaborator

mwaskom commented Apr 19, 2024

Ah nice, this bit me when I updated the Axolotl container version and I (falsely) attributed it to that.

I don't immediately understand why CI is failing but it seems not great?

@yirenlu92
Copy link
Contributor Author

oof yeah that is a lot of failing tests

@mwaskom
Copy link
Collaborator

mwaskom commented Apr 19, 2024

oh you deleted src/inference.py by accident :D

@yirenlu92
Copy link
Contributor Author

🤦‍♀️ sorry I had some local changes that I didn't want to include and forgot about that.

@charlesfrye
add back whitespace
c0ff760 
whitespace matters for LLMs due to tokenization!
@hamelsmu hamelsmu mentioned this pull request Apr 22, 2024
Merged
@charlesfrye
Copy link
Contributor

pulled this change into #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwaskom mwaskom Awaiting requested review from mwaskom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yirenlu92 @mwaskom @charlesfrye