Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our pyproject configuration #13

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Improve our pyproject configuration #13

merged 3 commits into from
Oct 11, 2024

Conversation

dsp-ant
Copy link
Member

@dsp-ant dsp-ant commented Oct 11, 2024

This updates our pyproject configuration by doing three thngs:

  • Adding our venv to the configuration so that pyright correctly picks it up
  • Pinning our python version to 3.11 for tools that support .python-version
  • Updating the ruff config to a new layout

pyright and Zed use the venv setting in pyright to correctly determine
the virtual env to use.
Tools like rye and uv use .python version to correctly lock the
venv to a certain python version. We are pinning ours to 3.11.
@dsp-ant dsp-ant mentioned this pull request Oct 11, 2024
@dsp-ant dsp-ant requested a review from jspahrsummers October 11, 2024 11:21
@dsp-ant dsp-ant merged commit 0ccff90 into main Oct 11, 2024
3 checks passed
@dsp-ant dsp-ant deleted the davidsp/pyproject branch October 11, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants