Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to protocol version 2024-10-07 #19

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

jspahrsummers
Copy link
Member

@jspahrsummers jspahrsummers commented Oct 21, 2024

Necessary to use the Python SDK with the latest versions of the inspector and example servers.

@jspahrsummers jspahrsummers requested a review from dsp-ant October 21, 2024 13:51
@@ -191,7 +210,7 @@ class ServerCapabilities(BaseModel):
class InitializeRequestParams(RequestParams):
"""Parameters for the initialize request."""

protocolVersion: Literal[1]
protocolVersion: str | int
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lenient version parsing for now.

@@ -211,7 +230,7 @@ class InitializeRequest(Request):
class InitializeResult(Result):
"""After receiving an initialize request from the client, the server sends this."""

protocolVersion: Literal[1]
protocolVersion: str | int
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lenient version parsing for now.

@jspahrsummers jspahrsummers merged commit 6cdd97b into main Oct 21, 2024
5 checks passed
@jspahrsummers jspahrsummers deleted the justin/upgrade-spec branch October 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants