Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated typing on request context for the server to use server session #217

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

jerome3o-anthropic
Copy link
Contributor

@jerome3o-anthropic jerome3o-anthropic commented Feb 19, 2025

Adding better type hinting for request context in fastmcp servers. This allows the IDE to provide autocomplete for things like .list_roots() and sampling.

Motivation and Context

Was writing a server that called list_roots

How Has This Been Tested?

Just a typing change, tests passing

Breaking Changes

Nope

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@jerome3o-anthropic jerome3o-anthropic force-pushed the jerome/fix/request-context-typing branch from eaf988f to 1e5f0c9 Compare February 19, 2025 13:35
@jerome3o-anthropic jerome3o-anthropic force-pushed the jerome/fix/request-context-typing branch from 1e5f0c9 to e0edadc Compare February 19, 2025 13:42
@jerome3o-anthropic jerome3o-anthropic marked this pull request as ready for review February 19, 2025 15:44
@dsp-ant dsp-ant merged commit 2628e01 into main Feb 20, 2025
5 checks passed
@dsp-ant dsp-ant deleted the jerome/fix/request-context-typing branch February 20, 2025 11:07
dsp-ant pushed a commit that referenced this pull request Feb 20, 2025
…context-typing

Updated typing on request context for the server to use server session
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants