Make merge_commit_sha nullable in GitHub server
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspahrsummers
previously approved these changes
Dec 5, 2024
jspahrsummers
approved these changes
Dec 5, 2024
laith-abood
pushed a commit
to laith-abood/mcp-claude
that referenced
this pull request
Jan 13, 2025
Make `merge_commit_sha` nullable in GitHub server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227.
Description
Server Details
Motivation and Context
Fixes #227 -
merge_commit_shawill be nullable immediately after a PR is created so should be marked as nullable otherwise the parsing will fail.How Has This Been Tested?
Tested locally with the changes to the server applied.
Breaking Changes
No
Types of changes
Checklist
Additional context