Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Puppeteer (Code & README) #4

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

maheshmurag
Copy link
Contributor

No description provided.

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Most of the changes look good, but I'm not sure about moving to a class. What are your thoughts?

},
];

class PuppeteerServer {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this OO style is very conventional for TypeScript servers (if we look at Node.js' built-in HTTP, Express, the Slack SDK, etc).

Can we leave it as free functions?

@maheshmurag maheshmurag merged commit 018c7d8 into main Nov 19, 2024
5 checks passed
@maheshmurag maheshmurag deleted the mahesh/update-puppeteer branch November 19, 2024 23:00
HarleyCoops pushed a commit to HarleyCoops/ClaudeServers that referenced this pull request Nov 28, 2024
…ahesh/update-puppeteer

Update Puppeteer (Code & README)
jspahrsummers pushed a commit that referenced this pull request Dec 12, 2024
Add mcp-server-rememberizer to community servers in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants