Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile path in sequentialthinking README #430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

po-shu
Copy link

@po-shu po-shu commented Dec 28, 2024

Description

sequentialthinking --> README.md --> Building --> Docker, The path to Dockerfile in the build command was incorrect.

incorrect

$ docker build -t mcp/sequentialthinking -f sequentialthinking/Dockerfile .

 => ERROR [builder 2/6] COPY src/sequentialthinking /app                                                                                                                                                                               0.0s
 => ERROR [builder 3/6] COPY tsconfig.json /tsconfig.json

correct

$ docker build -t mcp/sequentialthinking -f src/sequentialthinking/Dockerfile .

Fixed the Dockerfile path to properly execute from root directory like other MCP servers.

Server Details

  • Server: sequentialthinking
  • Changes to: README.md only

Motivation and Context

Docker users may become confused.

How Has This Been Tested?

  • Verified README formatting
  • Confirmed command and descriptions are accurate
  • Tested with Claude Desktop

Breaking Changes

No breaking changes - documentation update only.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant