Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong expression in dp_volumeFlowRate_MFLOW #4553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed wrong expression in dp_volumeFlowRate_MFLOW #4553

wants to merge 1 commit into from

Conversation

casella
Copy link
Contributor

@casella casella commented Feb 26, 2025

Fixes #4552.

HansOlsson
HansOlsson approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looking good and it fixes one of the unit-issues in the model.

(The other is the somewhat sloppy assert(a+b>0, "...") - but no need to rewrite that for 4.1.0.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

@wischhusen wischhusen Awaiting requested review from wischhusen

@hubertus65 hubertus65 Awaiting requested review from hubertus65

@arunkumar-narasimhan arunkumar-narasimhan Awaiting requested review from arunkumar-narasimhan

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in dp_volumeFlowRate_MFLOW() function
2 participants
@casella @HansOlsson