Suggestion for issue 92 #108
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmenne-dspace : is this ready for review to be possibly included in the v1beta1? |
Unfortunately, the pull request is not yet ready for merging. @msuevern wanted to integrate more things here. It is certainly a good idea to wait for the FlexRay part first. Depending on whether it is a time-based or message-based bus format, the description could differ. However, it only has a descriptive aspect in the general part and has no effect on the implementation of the CAN bus. I think it is not very relevant for beta.1 but just for the final release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#92