Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wolfram alpha service function #333

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Wolfram alpha service function #333

wants to merge 15 commits into from

Conversation

zyzhang1130
Copy link
Contributor

@zyzhang1130 zyzhang1130 commented Jul 11, 2024 •
edited
Loading

name: Pull Request
about: Create a pull request

Description

added wolfram alpha APIs as service function under src/agentscope/service/reasoning/wolfram_alpha.py. Details refer to the respective docstrings.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

ZiTao-Li
ZiTao-Li reviewed Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the inline comments:

  • Need to tell when to use which tools by more detail description and examples
  • Need to tell what is the expected content in the ServiceResponse.content, and its structure

src/agentscope/service/reasoning/wolfram_alpha.py Show resolved Hide resolved
src/agentscope/service/reasoning/wolfram_alpha.py Show resolved Hide resolved
ZiTao-Li
ZiTao-Li reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the English/Chinese tutorial tutorial/204-service.html

@zyzhang1130
Copy link
Contributor Author

LGTM. Please update the English/Chinese tutorial tutorial/204-service.html

Done.

DavdGao
DavdGao reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments, others lgtm

src/agentscope/service/__init__.py Outdated Show resolved Hide resolved
docs/sphinx_doc/zh_CN/source/tutorial/204-service.md Outdated Show resolved Hide resolved
src/agentscope/service/reasoning/wolfram_alpha.py Outdated Show resolved Hide resolved
src/agentscope/service/reasoning/wolfram_alpha.py Show resolved Hide resolved
src/agentscope/service/reasoning/wolfram_alpha.py Show resolved Hide resolved
src/agentscope/service/reasoning/wolfram_alpha.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiTao-Li ZiTao-Li ZiTao-Li left review comments

@DavdGao DavdGao DavdGao left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zyzhang1130 @DavdGao @ZiTao-Li