Fix a bug in checking local or remote file on Windows #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavdGao
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug that I came across during playing with the conversation_with_web_browser_agent example on Windows.
The bug was that OpenAI cannot access the local URL path because it is passed to the API as URL but not base64 format. This is caused by this line. urllib somehow parse the local path "C:\Users\xx" with C as the scheme, so the first branch of the if is executed, which means the file is checked as a web URL.
Not a good enough solution for now to add an exists check before the scheme check, but please feel free to discuss a more proper way.