-
Notifications
You must be signed in to change notification settings - Fork 91
linear2d_layer_no_bias: add optional argument to disable biases #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Should we extend this to all types of layers? |
@jvdp1 yep, I think we should |
Perhaps, I should rename it to FeedForward or MLP. Thoughts? |
I don't think MLP is appropriate because it refers to a network. We already have Regarding the question of whether this should be an option for all layers. My opinion depends on whether this is used more broadly in various layers. If it's used only in |
This also means that we could have a generic Alternatively, we could do: maxpool(pool_width=2) ! maxpool1d
maxpool(pool_width=2, pool_height=2) ! maxpool2d
maxpool(pool_width=2, pool_height=2, pool_depth=2) ! maxpool3d Same approach could apply to The more I think about this the more I like it. What do you think? |
@milancurcic Disregard the naming comment. It belongs in a different PR: #208 |
@milancurcic Should we merge it? I really would like to do it before the dense2d refactoring |
Yes, that's fine, please go ahead and squash-merge, thank you! |
Add option to disable biases
Simple additional option. Removing biases helps speed up inference. This technique is used in Llama and, to an extent, in Qwen. Being able to disable biases here is a simple quality of life addition