Video streaming #207
Merged
Video streaming #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the video player implementation using PyAV for decoding and ModernGL for rendering. The changes focus on improving the video decoding and playback functionality, enhancing error handling, and refining the user interface for video control.
Video Player Improvements:
examples/video.py: Refactored the video decoding and playback classes. TheDecoderclass has been renamed toVideoDecoder, and thePlayerclass has been renamed toVideoPlayer. Added better error handling, logging, and methods for seeking and frame generation.examples/video.py: Introduced constants for frame synchronization thresholds and improved theupdatemethod to handle frame skipping and synchronization more effectively.examples/video.py: Enhanced theVideoPlayerWindowclass to handle keyboard inputs for seeking and pausing, and added debug information printing.Bug Fixes:
moderngl_window/timers/clock.py: Fixed a potential division by zero error in thenext_framemethod by adding a check to ensuredeltais greater than zero before calculating the FPS.