Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-runner-coverage-v8): #2825 ignore invalid URLs #2827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miyasudokoro
Copy link

What I did

  1. In test-runner-coverage-v8 index.ts v8ToIstanbul, it now ignores V8Coverage entry.url that are not valid URLs. I did not use URL.canParse because @web/root has engines node: >=18.0.0.
  2. I moved the try-catch to surround the entire if-statement as an extra precaution for future issues.

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: dcce65d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/test-runner-coverage-v8 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@miyasudokoro
Copy link
Author

Just giving this a bump because I really do need it to be adopted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant