fix(usgcln) add explicit second dimension to util2d.load calls #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2097 +/- ##
=========================================
- Coverage 73.0% 73.0% -0.1%
=========================================
Files 259 259
Lines 59364 59364
=========================================
- Hits 43367 43359 -8
- Misses 15997 16005 +8
|
|
@cnicol-gwlogic if this is ready to go now, we could pull it in before 3.6.0 goes out. |
|
@wpbonelli thanbks - sorry i hadn't run the linting stuff...let's see if it passes :) |
|
looks good now, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Util2d.load expects two dimensions. MfusgCln was previously specifying only the first for 1d arrays, but util2d requires both.