Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(plotting): check for user set axes limits #2108

Merged
merged 2 commits into from
Feb 21, 2024
Merged

update(plotting): check for user set axes limits #2108

merged 2 commits into from
Feb 21, 2024

Conversation

jlarsen-usgs
Copy link
Contributor

  • added method to check for user supplied axes limits and set with default extents if autoscaling is on
  • update docstring in StructuredGrid.neighbors
  • add tests for axes limit checks and scaling

closes #2101

* added method to check for user supplied axes limits and set with default extents if autoscaling is on
* update docstring in StructuredGrid.neighbors
* add tests for axes limit checks and scaling
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (626563a) 73.0% compared to head (6e6aec9) 72.8%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2108     +/-   ##
=========================================
- Coverage     73.0%   72.8%   -0.2%     
=========================================
  Files          259     259             
  Lines        59415   59391     -24     
=========================================
- Hits         43401   43268    -133     
- Misses       16014   16123    +109     
Files Coverage Δ
flopy/discretization/structuredgrid.py 47.6% <ø> (ø)
flopy/plot/map.py 83.5% <91.6%> (-0.1%) ⬇️
flopy/plot/crosssection.py 66.8% <80.0%> (+0.4%) ⬆️

... and 11 files with indirect coverage changes

@jlarsen-usgs jlarsen-usgs merged commit 4e6f4c1 into modflowpy:develop Feb 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlotMapView resets limits of existing axes to entire model domain
1 participant